Commit 6bfa273e authored by Luiz Augusto von Dentz's avatar Luiz Augusto von Dentz
Browse files

Bluetooth: Consolidate code around sk_alloc into a helper function 



This consolidates code around sk_alloc into bt_sock_alloc which does
take care of common initialization.

Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent 6b42f04e

include/net/bluetooth/bluetooth.h

+2 −0
Original line number Diff line number Diff line
@@ -400,6 +400,8 @@ int bt_sock_register(int proto, const struct net_proto_family *ops); 
void bt_sock_unregister(int proto);

void bt_sock_link(struct bt_sock_list *l, struct sock *s);

void bt_sock_unlink(struct bt_sock_list *l, struct sock *s);

struct sock *bt_sock_alloc(struct net *net, struct socket *sock,

			   struct proto *prot, int proto, gfp_t prio, int kern);

int  bt_sock_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,

		     int flags);

int  bt_sock_stream_recvmsg(struct socket *sock, struct msghdr *msg,

net/bluetooth/af_bluetooth.c

+21 −0
Original line number Diff line number Diff line
@@ -140,6 +140,27 @@ static int bt_sock_create(struct net *net, struct socket *sock, int proto, 
	return err;

}



struct sock *bt_sock_alloc(struct net *net, struct socket *sock,

			   struct proto *prot, int proto, gfp_t prio, int kern)

{

	struct sock *sk;



	sk = sk_alloc(net, PF_BLUETOOTH, prio, prot, kern);

	if (!sk)

		return NULL;



	sock_init_data(sock, sk);

	INIT_LIST_HEAD(&bt_sk(sk)->accept_q);



	sock_reset_flag(sk, SOCK_ZAPPED);



	sk->sk_protocol = proto;

	sk->sk_state    = BT_OPEN;



	return sk;

}

EXPORT_SYMBOL(bt_sock_alloc);



void bt_sock_link(struct bt_sock_list *l, struct sock *sk)

{

	write_lock(&l->lock);

net/bluetooth/bnep/sock.c

+1 −9
Original line number Diff line number Diff line
@@ -205,21 +205,13 @@ static int bnep_sock_create(struct net *net, struct socket *sock, int protocol, 
	if (sock->type != SOCK_RAW)

		return -ESOCKTNOSUPPORT;



	sk = sk_alloc(net, PF_BLUETOOTH, GFP_ATOMIC, &bnep_proto, kern);

	sk = bt_sock_alloc(net, sock, &bnep_proto, protocol, GFP_ATOMIC, kern);

	if (!sk)

		return -ENOMEM;



	sock_init_data(sock, sk);



	sock->ops = &bnep_sock_ops;



	sock->state = SS_UNCONNECTED;



	sock_reset_flag(sk, SOCK_ZAPPED);



	sk->sk_protocol = protocol;

	sk->sk_state	= BT_OPEN;



	bt_sock_link(&bnep_sk_list, sk);

	return 0;

}

net/bluetooth/hci_sock.c

+2 −8
Original line number Diff line number Diff line
@@ -2143,18 +2143,12 @@ static int hci_sock_create(struct net *net, struct socket *sock, int protocol, 


	sock->ops = &hci_sock_ops;



	sk = sk_alloc(net, PF_BLUETOOTH, GFP_ATOMIC, &hci_sk_proto, kern);

	sk = bt_sock_alloc(net, sock, &hci_sk_proto, protocol, GFP_ATOMIC,

			   kern);

	if (!sk)

		return -ENOMEM;



	sock_init_data(sock, sk);



	sock_reset_flag(sk, SOCK_ZAPPED);



	sk->sk_protocol = protocol;



	sock->state = SS_UNCONNECTED;

	sk->sk_state = BT_OPEN;

	sk->sk_destruct = hci_sock_destruct;



	bt_sock_link(&hci_sk_list, sk);

net/bluetooth/iso.c

+1 −9
Original line number Diff line number Diff line
@@ -738,21 +738,13 @@ static struct sock *iso_sock_alloc(struct net *net, struct socket *sock, 
{

	struct sock *sk;



	sk = sk_alloc(net, PF_BLUETOOTH, prio, &iso_proto, kern);

	sk = bt_sock_alloc(net, sock, &iso_proto, proto, prio, kern);

	if (!sk)

		return NULL;



	sock_init_data(sock, sk);

	INIT_LIST_HEAD(&bt_sk(sk)->accept_q);



	sk->sk_destruct = iso_sock_destruct;

	sk->sk_sndtimeo = ISO_CONN_TIMEOUT;



	sock_reset_flag(sk, SOCK_ZAPPED);



	sk->sk_protocol = proto;

	sk->sk_state    = BT_OPEN;



	/* Set address type as public as default src address is BDADDR_ANY */

	iso_pi(sk)->src_type = BDADDR_LE_PUBLIC;