Commit 6bf06f14 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Hans de Goede
Browse files

platform/x86: wmi: Replace open coded guid_parse_and_compare() 



Even though we have no issues in the code, let's replace the open
coded guid_parse_and_compare().

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230621151155.78279-2-andriy.shevchenko@linux.intel.com


Tested-by: default avatarArmin Wolf <W_Armin@gmx.de>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 028e6e20

drivers/platform/x86/wmi.c

+1 −5
Original line number Diff line number Diff line
@@ -1241,11 +1241,7 @@ static bool guid_already_parsed_for_legacy(struct acpi_device *device, const gui 
	list_for_each_entry(wblock, &wmi_block_list, list) {

		/* skip warning and register if we know the driver will use struct wmi_driver */

		for (int i = 0; allow_duplicates[i] != NULL; i++) {

			guid_t tmp;



			if (guid_parse(allow_duplicates[i], &tmp))

				continue;

			if (guid_equal(&tmp, guid))

			if (guid_parse_and_compare(allow_duplicates[i], guid))

				return false;

		}

		if (guid_equal(&wblock->gblock.guid, guid)) {