Commit 6bea9ea6 authored by Vladislav Efanov's avatar Vladislav Efanov Committed by Greg Kroah-Hartman
Browse files

isa: Remove unnecessary checks 



The isa_dev->dev.platform_data is initialized with incoming
parameter isa_driver. After it isa_dev->dev.platform_data is
checked for NULL, but incoming parameter isa_driver is not
NULL since it is dereferenced many times before this check.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarVladislav Efanov <VEfanov@ispras.ru>
Acked-by: default avatarWilliam Breathitt Gray <william.gray@linaro.org>
Link: https://lore.kernel.org/r/20230517125025.434005-1-VEfanov@ispras.ru


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 54aa5b60

drivers/base/isa.c

+2 −5
Original line number Diff line number Diff line
@@ -149,11 +149,8 @@ int isa_register_driver(struct isa_driver *isa_driver, unsigned int ndev) 
			break;

		}



		if (isa_dev->dev.platform_data) {

		isa_dev->next = isa_driver->devices;

		isa_driver->devices = &isa_dev->dev;

		} else

			device_unregister(&isa_dev->dev);

	}



	if (!error && !isa_driver->devices)