Commit 6bbe1065 authored by Nícolas F. R. A. Prado's avatar Nícolas F. R. A. Prado Committed by Mathieu Poirier
Browse files

dt-bindings: remoteproc: mediatek: Make l1tcm reg exclusive to mt819x 



Commit ca23ecfd ("remoteproc/mediatek: support L1TCM") added support
for the l1tcm memory region on the MT8192 SCP, adding a new da_to_va
callback that handles l1tcm while keeping the old one for
back-compatibility with MT8183. However, since the mt8192 compatible was
missing from the dt-binding, the accompanying dt-binding commit
503c64cc ("dt-bindings: remoteproc: mediatek: add L1TCM memory region")
mistakenly added this reg as if it were for mt8183. And later
it became common to all platforms as their compatibles were added.

Fix the dt-binding so that the l1tcm reg can be present only on the
supported platforms: mt8192 and mt8195.

Fixes: 503c64cc ("dt-bindings: remoteproc: mediatek: add L1TCM memory region")
Signed-off-by: default avatarNícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220511195452.871897-2-nfraprado@collabora.com


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent be1de12c

Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml

+30 −14
Original line number Diff line number Diff line
@@ -23,11 +23,13 @@ properties: 


  reg:

    description:

      Should contain the address ranges for memory regions SRAM, CFG, and

      L1TCM.

      Should contain the address ranges for memory regions SRAM, CFG, and,

      on some platforms, L1TCM.

    minItems: 2

    maxItems: 3



  reg-names:

    minItems: 2

    items:

      - const: sram

      - const: cfg
@@ -57,7 +59,8 @@ required: 
  - reg

  - reg-names



if:

allOf:

  - if:

      properties:

        compatible:

          enum:
@@ -68,6 +71,19 @@ then: 
        - clocks

        - clock-names



  - if:

      properties:

        compatible:

          enum:

            - mediatek,mt8183-scp

            - mediatek,mt8186-scp

    then:

      properties:

        reg:

          maxItems: 2

        reg-names:

          maxItems: 2



additionalProperties:

  type: object

  description:
@@ -86,10 +102,10 @@ additionalProperties: 


examples:

  - |

    #include <dt-bindings/clock/mt8183-clk.h>

    #include <dt-bindings/clock/mt8192-clk.h>



    scp@10500000 {

        compatible = "mediatek,mt8183-scp";

        compatible = "mediatek,mt8192-scp";

        reg = <0x10500000 0x80000>,

              <0x10700000 0x8000>,

              <0x10720000 0xe0000>;