Commit 6bb5318c authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

Merge branch 'net-fix-use-after-free-bugs' 

Pavel Skripkin says:

====================
net: fix use-after-free bugs

I've added new checker to smatch yesterday. It warns about using
netdev_priv() pointer after free_{netdev,candev}() call. I hope, it will
get into next smatch release.

Some of the reported bugs are fixed and upstreamed already, but Dan ran new
smatch with allmodconfig and found 2 more. Big thanks to Dan for doing it,
because I totally forgot to do it.
====================

Link: https://lore.kernel.org/r/cover.1628091954.git.paskripkin@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parents af35fc37 942e560a

drivers/net/ethernet/freescale/fec_main.c

+1 −1
Original line number Diff line number Diff line
@@ -3843,13 +3843,13 @@ fec_drv_remove(struct platform_device *pdev) 
	if (of_phy_is_fixed_link(np))

		of_phy_deregister_fixed_link(np);

	of_node_put(fep->phy_node);

	free_netdev(ndev);



	clk_disable_unprepare(fep->clk_ahb);

	clk_disable_unprepare(fep->clk_ipg);

	pm_runtime_put_noidle(&pdev->dev);

	pm_runtime_disable(&pdev->dev);



	free_netdev(ndev);

	return 0;

}

drivers/net/ethernet/neterion/vxge/vxge-main.c

+3 −3
Original line number Diff line number Diff line
@@ -3512,13 +3512,13 @@ static void vxge_device_unregister(struct __vxge_hw_device *hldev) 


	kfree(vdev->vpaths);



	/* we are safe to free it now */

	free_netdev(dev);



	vxge_debug_init(vdev->level_trace, "%s: ethernet device unregistered",

			buf);

	vxge_debug_entryexit(vdev->level_trace,	"%s: %s:%d  Exiting...", buf,

			     __func__, __LINE__);



	/* we are safe to free it now */

	free_netdev(dev);

}



/*