Commit 6b8646a9 authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

torture: Wake up kthreads after storing task_struct pointer 



Currently, _torture_create_kthread() uses kthread_run() to create
torture-test kthreads, which means that the resulting task_struct
pointer is stored after the newly created kthread has been marked
runnable.  This in turn can cause spurious failure of checks for
code being run by a particular kthread.  This commit therefore changes
_torture_create_kthread() to use kthread_create(), then to do an explicit
wake_up_process() after the task_struct pointer has been stored.

Reported-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Reviewed-by: default avatarNeeraj Upadhyay <quic_neeraju@quicinc.com>
Reviewed-by: default avatarUladzislau Rezki (Sony) <urezki@gmail.com>
Reviewed-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent 89440d2d

kernel/torture.c

+3 −1
Original line number Diff line number Diff line
@@ -931,12 +931,14 @@ int _torture_create_kthread(int (*fn)(void *arg), void *arg, char *s, char *m, 
	int ret = 0;



	VERBOSE_TOROUT_STRING(m);

	*tp = kthread_run(fn, arg, "%s", s);

	*tp = kthread_create(fn, arg, "%s", s);

	if (IS_ERR(*tp)) {

		ret = PTR_ERR(*tp);

		TOROUT_ERRSTRING(f);

		*tp = NULL;

		return ret;

	}

	wake_up_process(*tp);  // Process is sleeping, so ordering provided.

	torture_shuffle_task_register(*tp);

	return ret;

}