Commit 6b72cf12 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

drivers/base/cpu: remove redundant assignment of variable retval 



The variable retval is being initialized with a value that is never read
and it is being updated later with a new value.  Clean this up by
initializing retval to -ENOMEM and remove the assignment to retval
on the !dev failure path.

Kudos to Rafael for the improved fix suggestion.

Reviewed-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210218202837.516231-1-colin.king@canonical.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2c137388

drivers/base/cpu.c

+2 −4
Original line number Diff line number Diff line
@@ -409,13 +409,11 @@ __cpu_device_create(struct device *parent, void *drvdata, 
		    const char *fmt, va_list args)

{

	struct device *dev = NULL;

	int retval = -ENODEV;

	int retval = -ENOMEM;



	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (!dev) {

		retval = -ENOMEM;

	if (!dev)

		goto error;

	}



	device_initialize(dev);

	dev->parent = parent;