Commit 6b5f5900 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

SUNRPC: Remove redundant calls to RPC_IS_QUEUED() 



The RPC task wakeup calls all check for RPC_IS_QUEUED() before taking any
locks. In addition, rpc_exit() already calls rpc_wake_up_queued_task().

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent cea57789

net/sunrpc/clnt.c

+0 −3
Original line number Diff line number Diff line
@@ -833,9 +833,6 @@ void rpc_killall_tasks(struct rpc_clnt *clnt) 
		if (!(rovr->tk_flags & RPC_TASK_KILLED)) {

			rovr->tk_flags |= RPC_TASK_KILLED;

			rpc_exit(rovr, -EIO);

			if (RPC_IS_QUEUED(rovr))

				rpc_wake_up_queued_task(rovr->tk_waitqueue,

							rovr);

		}

	}

	spin_unlock(&clnt->cl_lock);

net/sunrpc/sched.c

+1 −2
Original line number Diff line number Diff line
@@ -785,7 +785,6 @@ void rpc_exit(struct rpc_task *task, int status) 
{

	task->tk_status = status;

	task->tk_action = rpc_exit_task;

	if (RPC_IS_QUEUED(task))

	rpc_wake_up_queued_task(task->tk_waitqueue, task);

}

EXPORT_SYMBOL_GPL(rpc_exit);