Commit 6b50cf45 authored by Roi Dayan's avatar Roi Dayan Committed by Saeed Mahameed
Browse files

net/mlx5e: Check action fwd/drop flag exists also for nic flows 



The driver should add offloaded rules with either a fwd or drop action.
The check existed in parsing fdb flows but not when parsing nic flows.
Move the test into actions_match_supported() which is called for
checking nic flows and fdb flows.

Signed-off-by: default avatarRoi Dayan <roid@nvidia.com>
Reviewed-by: default avatarMaor Dickman <maord@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 7f8770c7

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+6 −7
Original line number Diff line number Diff line
@@ -3189,6 +3189,12 @@ static bool actions_match_supported(struct mlx5e_priv *priv, 
	ct_flow = flow_flag_test(flow, CT) && !ct_clear;

	actions = flow->attr->action;



	if (!(actions &

	      (MLX5_FLOW_CONTEXT_ACTION_FWD_DEST | MLX5_FLOW_CONTEXT_ACTION_DROP))) {

		NL_SET_ERR_MSG_MOD(extack, "Rule must have at least one forward/drop action");

		return false;

	}



	if (mlx5e_is_eswitch_flow(flow)) {

		if (flow->attr->esw_attr->split_count && ct_flow &&

		    !MLX5_CAP_GEN(flow->attr->esw_attr->in_mdev, reg_c_preserve)) {
@@ -4077,13 +4083,6 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, 
		return -EOPNOTSUPP;

	}



	if (!(attr->action &

	      (MLX5_FLOW_CONTEXT_ACTION_FWD_DEST | MLX5_FLOW_CONTEXT_ACTION_DROP))) {

		NL_SET_ERR_MSG_MOD(extack,

				   "Rule must have at least one forward/drop action");

		return -EOPNOTSUPP;

	}



	if (esw_attr->split_count > 0 && !mlx5_esw_has_fwd_fdb(priv->mdev)) {

		NL_SET_ERR_MSG_MOD(extack,

				   "current firmware doesn't support split rule for port mirroring");