Commit 6b504d06 authored by Nilesh Javali's avatar Nilesh Javali Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Avoid fcport pointer dereference 



Klocwork reported warning of NULL pointer may be dereferenced.  The routine
exits when sa_ctl is NULL and fcport is allocated after the exit call thus
causing NULL fcport pointer to dereference at the time of exit.

To avoid fcport pointer dereference, exit the routine when sa_ctl is NULL.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarNilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20230607113843.37185-4-njavali@marvell.com


Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 464ea494

drivers/scsi/qla2xxx/qla_edif.c

+2 −2
Original line number Diff line number Diff line
@@ -2362,7 +2362,7 @@ qla24xx_issue_sa_replace_iocb(scsi_qla_host_t *vha, struct qla_work_evt *e) 
		ql_dbg(ql_dbg_edif, vha, 0x70e6,

		    "sa_ctl allocation failed\n");

		rval = -ENOMEM;

		goto done;

		return rval;

	}



	fcport = sa_ctl->fcport;