Commit 6b48bece authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Jakub Kicinski
Browse files

net: nixge: Use GFP_KERNEL instead of GFP_ATOMIC when possible 



NIXGE_MAX_JUMBO_FRAME_SIZE is over 9000 bytes and RX_BD_NUM 128.

So this loop allocates more than 1 Mo of memory.

Previous memory allocations in this function already use GFP_KERNEL, so
use __netdev_alloc_skb_ip_align() and an explicit GFP_KERNEL instead of a
implicit GFP_ATOMIC.

This gives more opportunities of successful allocation.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/28d2c8e05951ad02a57eb48333672947c8bb4f81.1645043881.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3ad8ba6a

drivers/net/ethernet/ni/nixge.c

+3 −2
Original line number Diff line number Diff line
@@ -324,8 +324,9 @@ static int nixge_hw_dma_bd_init(struct net_device *ndev) 
					 + sizeof(*priv->rx_bd_v) *

					 ((i + 1) % RX_BD_NUM));



		skb = netdev_alloc_skb_ip_align(ndev,

						NIXGE_MAX_JUMBO_FRAME_SIZE);

		skb = __netdev_alloc_skb_ip_align(ndev,

						  NIXGE_MAX_JUMBO_FRAME_SIZE,

						  GFP_KERNEL);

		if (!skb)

			goto out;