Commit 6ae435bd authored Mar 02, 2021 by Pierre-Louis Bossart Committed by Vinod Koul Mar 30, 2021

soundwire: generic_bandwidth_allocation: remove useless init



Cppcheck complains about two possible null pointer dereferences, but
it's more like there are unnecessary initializations before walking
through a list.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210302091122.13952-8-yung-chuan.liao@linux.intel.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 1429cc26

drivers/soundwire/generic_bandwidth_allocation.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -143,7 +143,7 @@ static void sdw_compute_master_ports(struct sdw_master_runtime *m_rt,
		static void _sdw_compute_port_params(struct sdw_bus *bus,
		struct sdw_group_params *params, int count)
		{
		struct sdw_master_runtime *m_rt = NULL;
		struct sdw_master_runtime *m_rt;
		int hstop = bus->params.col - 1;
		int block_offset, port_bo, i;

		@@ -169,7 +169,7 @@ static int sdw_compute_group_params(struct sdw_bus *bus,
		struct sdw_group_params *params,
		int *rates, int count)
		{
		struct sdw_master_runtime *m_rt = NULL;
		struct sdw_master_runtime *m_rt;
		int sel_col = bus->params.col;
		unsigned int rate, bps, ch;
		int i, column_needed = 0;