Commit 6adc4601 authored by Jonathan Lemon's avatar Jonathan Lemon Committed by Jakub Kicinski
Browse files

bnxt: apply computed clamp value for coalece parameter 



After executing "ethtool -C eth0 rx-usecs-irq 0", the box becomes
unresponsive, likely due to interrupt livelock.  It appears that
a minimum clamp value for the irq timer is computed, but is never
applied.

Fix by applying the corrected clamp value.

Fixes: 74706afa ("bnxt_en: Update interrupt coalescing logic.")
Signed-off-by: default avatarJonathan Lemon <jonathan.lemon@gmail.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
parent 692b93af

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+1 −1
Original line number Diff line number Diff line
@@ -6190,7 +6190,7 @@ static void bnxt_hwrm_set_coal_params(struct bnxt *bp, 
		tmr = bnxt_usec_to_coal_tmr(bp, hw_coal->coal_ticks_irq);

		val = clamp_t(u16, tmr, 1,

			      coal_cap->cmpl_aggr_dma_tmr_during_int_max);

		req->cmpl_aggr_dma_tmr_during_int = cpu_to_le16(tmr);

		req->cmpl_aggr_dma_tmr_during_int = cpu_to_le16(val);

		req->enables |=

			cpu_to_le16(BNXT_COAL_CMPL_AGGR_TMR_DURING_INT_ENABLE);

	}