Commit 6adc32f5 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Lee Jones
Browse files

EDAC, pnd2: Use proper I/O accessors and address space annotation 



The driver uses rather voodoo kind of castings and I/O accessors.
Replace it with proper __iomem annotation and readl()/readq() calls.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: default avatarHenning Schild <henning.schild@siemens.com>
Reviewed-by: default avatarTony Luck <tony.luck@intel.com>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 5c7b9167

drivers/edac/pnd2_edac.c

+4 −3
Original line number Diff line number Diff line
@@ -265,7 +265,7 @@ static u64 get_sideband_reg_base_addr(void) 
static int dnv_rd_reg(int port, int off, int op, void *data, size_t sz, char *name)

{

	struct pci_dev *pdev;

	char *base;

	void __iomem *base;

	u64 addr;

	unsigned long size;
@@ -297,8 +297,9 @@ static int dnv_rd_reg(int port, int off, int op, void *data, size_t sz, char *na 
			return -ENODEV;



		if (sz == 8)

			*(u32 *)(data + 4) = *(u32 *)(base + off + 4);

		*(u32 *)data = *(u32 *)(base + off);

			*(u64 *)data = readq(base + off);

		else

			*(u32 *)data = readl(base + off);



		iounmap(base);

	}