Commit 6ac66cb0 authored by Sriram Yagnaraman's avatar Sriram Yagnaraman Committed by David S. Miller
Browse files

ipv4: ignore dst hint for multipath routes 



Route hints when the nexthop is part of a multipath group causes packets
in the same receive batch to be sent to the same nexthop irrespective of
the multipath hash of the packet. So, do not extract route hint for
packets whose destination is part of a multipath group.

A new SKB flag IPSKB_MULTIPATH is introduced for this purpose, set the
flag when route is looked up in ip_mkroute_input() and use it in
ip_extract_route_hint() to check for the existence of the flag.

Fixes: 02b24941 ("ipv4: use dst hint for ipv4 list receive")
Signed-off-by: default avatarSriram Yagnaraman <sriram.yagnaraman@est.tech>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2ea35288

include/net/ip.h

+1 −0
Original line number Diff line number Diff line
@@ -57,6 +57,7 @@ struct inet_skb_parm { 
#define IPSKB_FRAG_PMTU		BIT(6)

#define IPSKB_L3SLAVE		BIT(7)

#define IPSKB_NOPOLICY		BIT(8)

#define IPSKB_MULTIPATH		BIT(9)



	u16			frag_max_size;

};

net/ipv4/ip_input.c

+2 −1
Original line number Diff line number Diff line
@@ -584,7 +584,8 @@ static void ip_sublist_rcv_finish(struct list_head *head) 
static struct sk_buff *ip_extract_route_hint(const struct net *net,

					     struct sk_buff *skb, int rt_type)

{

	if (fib4_has_custom_rules(net) || rt_type == RTN_BROADCAST)

	if (fib4_has_custom_rules(net) || rt_type == RTN_BROADCAST ||

	    IPCB(skb)->flags & IPSKB_MULTIPATH)

		return NULL;



	return skb;

net/ipv4/route.c

+1 −0
Original line number Diff line number Diff line
@@ -2144,6 +2144,7 @@ static int ip_mkroute_input(struct sk_buff *skb, 
		int h = fib_multipath_hash(res->fi->fib_net, NULL, skb, hkeys);



		fib_select_multipath(res, h);

		IPCB(skb)->flags |= IPSKB_MULTIPATH;

	}

#endif