Commit 6a8b7e80 authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Jens Wiklander
Browse files

tee: optee: Use kmemdup() to replace kmalloc + memcpy 



Use kmemdup rather than duplicating its implementation.

./drivers/tee/optee/smc_abi.c:1542:12-19: WARNING opportunity for kmemdup.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5480


Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: default avatarSumit Garg <sumit.garg@linaro.org>
Signed-off-by: default avatarJens Wiklander <jens.wiklander@linaro.org>
parent f1fcbaa1

drivers/tee/optee/smc_abi.c

+1 −2
Original line number Diff line number Diff line
@@ -1539,12 +1539,11 @@ static int optee_load_fw(struct platform_device *pdev, 
	 * This uses the GFP_DMA flag to ensure we are allocated memory in the

	 * 32-bit space since TF-A cannot map memory beyond the 32-bit boundary.

	 */

	data_buf = kmalloc(fw->size, GFP_KERNEL | GFP_DMA);

	data_buf = kmemdup(fw->data, fw->size, GFP_KERNEL | GFP_DMA);

	if (!data_buf) {

		rc = -ENOMEM;

		goto fw_err;

	}

	memcpy(data_buf, fw->data, fw->size);

	data_pa = virt_to_phys(data_buf);

	reg_pair_from_64(&data_pa_high, &data_pa_low, data_pa);

	reg_pair_from_64(&data_size_high, &data_size_low, data_size);