Unverified Commit 6a7f5bd6 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: qcom: lpass-cpu: mark IRQ_CLEAR register as volatile and readable 



Currently IRQ_CLEAR register is marked as write-only, however using
regmap_update_bits on this register will have some side effects.
so mark IRQ_CLEAR register appropriately as readable and volatile.

Fixes: da0363f7 ("ASoC: qcom: Fix for DMA interrupt clear reg overwriting")
Reported-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Tested-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Tested-by: default avatarSrinivasa Rao Mandadapu <srivasam@codeaurora.org>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210624092153.5771-1-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8cc802bd

sound/soc/qcom/lpass-cpu.c

+6 −1
Original line number Diff line number Diff line
@@ -525,6 +525,8 @@ static bool lpass_cpu_regmap_readable(struct device *dev, unsigned int reg) 
			return true;



	for (i = 0; i < v->irq_ports; ++i) {

		if (reg == LPAIF_IRQCLEAR_REG(v, i))

			return true;

		if (reg == LPAIF_IRQEN_REG(v, i))

			return true;

		if (reg == LPAIF_IRQSTAT_REG(v, i))
@@ -566,9 +568,12 @@ static bool lpass_cpu_regmap_volatile(struct device *dev, unsigned int reg) 
	struct lpass_variant *v = drvdata->variant;

	int i;



	for (i = 0; i < v->irq_ports; ++i)

	for (i = 0; i < v->irq_ports; ++i) {

		if (reg == LPAIF_IRQCLEAR_REG(v, i))

			return true;

		if (reg == LPAIF_IRQSTAT_REG(v, i))

			return true;

	}



	for (i = 0; i < v->rdma_channels; ++i)

		if (reg == LPAIF_RDMACURR_REG(v, i))