Commit 6a7d6b4c authored by Pali Rohár's avatar Pali Rohár Committed by Long Li
Browse files

cifs: Fix buffer overflow when parsing NFS reparse points 

mainline inclusion
from mainline-v6.10-rc2
commit e2a8910af01653c1c268984855629d71fb81f404
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IAYRA3
CVE: CVE-2024-49996

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e2a8910af01653c1c268984855629d71fb81f404



--------------------------------

ReparseDataLength is sum of the InodeType size and DataBuffer size.
So to get DataBuffer size it is needed to subtract InodeType's size from
ReparseDataLength.

Function cifs_strndup_from_utf16() is currentlly accessing buf->DataBuffer
at position after the end of the buffer because it does not subtract
InodeType size from the length. Fix this problem and correctly subtract
variable len.

Member InodeType is present only when reparse buffer is large enough. Check
for ReparseDataLength before accessing InodeType to prevent another invalid
memory access.

Major and minor rdev values are present also only when reparse buffer is
large enough. Check for reparse buffer size before calling reparse_mkdev().

Fixes: d5ecebc4 ("smb3: Allow query of symlinks stored as reparse points")
Reviewed-by: default avatarPaulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Signed-off-by: default avatarLong Li <leo.lilong@huawei.com>
parent 0e97fcf9

fs/smb/client/reparse.c

+14 −1
Original line number Diff line number Diff line
@@ -320,9 +320,16 @@ static int parse_reparse_posix(struct reparse_posix_data *buf, 
	unsigned int len;

	u64 type;



	len = le16_to_cpu(buf->ReparseDataLength);

	if (len < sizeof(buf->InodeType)) {

		cifs_dbg(VFS, "srv returned malformed nfs buffer\n");

		return -EIO;

	}



	len -= sizeof(buf->InodeType);



	switch ((type = le64_to_cpu(buf->InodeType))) {

	case NFS_SPECFILE_LNK:

		len = le16_to_cpu(buf->ReparseDataLength);

		data->symlink_target = cifs_strndup_from_utf16(buf->DataBuffer,

							       len, true,

							       cifs_sb->local_nls);
@@ -482,12 +489,18 @@ bool cifs_reparse_point_to_fattr(struct cifs_sb_info *cifs_sb, 
	u32 tag = data->reparse.tag;



	if (tag == IO_REPARSE_TAG_NFS && buf) {

		if (le16_to_cpu(buf->ReparseDataLength) < sizeof(buf->InodeType))

			return false;

		switch (le64_to_cpu(buf->InodeType)) {

		case NFS_SPECFILE_CHR:

			if (le16_to_cpu(buf->ReparseDataLength) != sizeof(buf->InodeType) + 8)

				return false;

			fattr->cf_mode |= S_IFCHR;

			fattr->cf_rdev = reparse_mkdev(buf->DataBuffer);

			break;

		case NFS_SPECFILE_BLK:

			if (le16_to_cpu(buf->ReparseDataLength) != sizeof(buf->InodeType) + 8)

				return false;

			fattr->cf_mode |= S_IFBLK;

			fattr->cf_rdev = reparse_mkdev(buf->DataBuffer);

			break;