Commit 6a71ca74 authored by Rob Herring's avatar Rob Herring
Browse files

sparc: Use of_property_present() for testing DT property presence 

It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Link: https://lore.kernel.org/r/20230310144659.1541247-1-robh@kernel.org


Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 6bb1504d

arch/sparc/kernel/of_device_32.c

+2 −2
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ static int of_bus_pci_match(struct device_node *np) 
		 * parent as-is, not with the PCI translate

		 * method which chops off the top address cell.

		 */

		if (!of_find_property(np, "ranges", NULL))

		if (!of_property_present(np, "ranges"))

			return 0;



		return 1;
@@ -223,7 +223,7 @@ static int __init build_one_resource(struct device_node *parent, 
static int __init use_1to1_mapping(struct device_node *pp)

{

	/* If we have a ranges property in the parent, use it.  */

	if (of_find_property(pp, "ranges", NULL) != NULL)

	if (of_property_present(pp, "ranges"))

		return 0;



	/* Some SBUS devices use intermediate nodes to express

arch/sparc/kernel/of_device_64.c

+3 −3
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ static int of_bus_pci_match(struct device_node *np) 
		 * parent as-is, not with the PCI translate

		 * method which chops off the top address cell.

		 */

		if (!of_find_property(np, "ranges", NULL))

		if (!of_property_present(np, "ranges"))

			return 0;



		return 1;
@@ -78,7 +78,7 @@ static int of_bus_simba_match(struct device_node *np) 
	 * simba.

	 */

	if (of_node_name_eq(np, "pci")) {

		if (!of_find_property(np, "ranges", NULL))

		if (!of_property_present(np, "ranges"))

			return 1;

	}
@@ -283,7 +283,7 @@ static int __init build_one_resource(struct device_node *parent, 
static int __init use_1to1_mapping(struct device_node *pp)

{

	/* If we have a ranges property in the parent, use it.  */

	if (of_find_property(pp, "ranges", NULL) != NULL)

	if (of_property_present(pp, "ranges"))

		return 0;



	/* If the parent is the dma node of an ISA bus, pass

arch/sparc/kernel/of_device_common.c

+1 −1
Original line number Diff line number Diff line
@@ -162,7 +162,7 @@ int of_bus_sbus_match(struct device_node *np) 
		 * don't have some intervening real bus that provides

		 * ranges based translations.

		 */

		if (of_find_property(dp, "ranges", NULL) != NULL)

		if (of_property_present(dp, "ranges"))

			break;



		dp = dp->parent;

arch/sparc/kernel/prom_64.c

+1 −1
Original line number Diff line number Diff line
@@ -502,7 +502,7 @@ static void *fill_in_one_cpu(struct device_node *dp, int cpuid, int arg) 
	struct device_node *portid_parent = NULL;

	int portid = -1;



	if (of_find_property(dp, "cpuid", NULL)) {

	if (of_property_present(dp, "cpuid")) {

		int limit = 2;



		portid_parent = dp;

arch/sparc/kernel/time_32.c

+1 −1
Original line number Diff line number Diff line
@@ -277,7 +277,7 @@ static int clock_probe(struct platform_device *op) 
		return -ENODEV;



	/* Only the primary RTC has an address property */

	if (!of_find_property(dp, "address", NULL))

	if (!of_property_present(dp, "address"))

		return -ENODEV;



	m48t59_rtc.resource = &op->resource[0];