Commit 6a628fa4 authored by Alexander Aring's avatar Alexander Aring Committed by David Teigland
Browse files

fs: dlm: fix potential buffer overflow 



This patch fixes an potential overflow in sscanf and the maximum
declared string parsing length which seems to be excluding the null
termination symbol. This patch will just add one byte to be prepared on
a string with length of DLM_RESNAME_MAXLEN including the null
termination symbol.

Fixes: 5054e79d ("fs: dlm: add lkb debugfs functionality")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
parent c8b9f34e

fs/dlm/debug_fs.c

+1 −1
Original line number Diff line number Diff line
@@ -640,7 +640,7 @@ static ssize_t table_write2(struct file *file, const char __user *user_buf, 
{

	struct seq_file *seq = file->private_data;

	int n, len, lkb_nodeid, lkb_status, error;

	char name[DLM_RESNAME_MAXLEN] = {};

	char name[DLM_RESNAME_MAXLEN + 1] = {};

	struct dlm_ls *ls = seq->private;

	unsigned int lkb_flags;

	char buf[256] = {};