Commit 6a37d750 authored by Michal Simek's avatar Michal Simek Committed by Linus Walleij
Browse files

pinctrl: core: Set ret to 0 when group is skipped 



Static analyzer tool found that the ret variable is not initialized but
code expects ret value >=0 when pinconf is skipped in the first pinmux
loop. The same expectation is for pinmux in a pinconf loop.
That's why initialize ret to 0 to avoid uninitialized ret value in first
loop or reusing ret value from first loop in second.

Addresses-Coverity: ("Uninitialized variables")
Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarColin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/e5203bae68eb94b4b8b4e67e5e7b4d86bb989724.1615534291.git.michal.simek@xilinx.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 47386ce3

drivers/pinctrl/core.c

+2 −0
Original line number Diff line number Diff line
@@ -1266,6 +1266,7 @@ static int pinctrl_commit_state(struct pinctrl *p, struct pinctrl_state *state) 
			break;

		case PIN_MAP_TYPE_CONFIGS_PIN:

		case PIN_MAP_TYPE_CONFIGS_GROUP:

			ret = 0;

			break;

		default:

			ret = -EINVAL;
@@ -1284,6 +1285,7 @@ static int pinctrl_commit_state(struct pinctrl *p, struct pinctrl_state *state) 
	list_for_each_entry(setting, &state->settings, node) {

		switch (setting->type) {

		case PIN_MAP_TYPE_MUX_GROUP:

			ret = 0;

			break;

		case PIN_MAP_TYPE_CONFIGS_PIN:

		case PIN_MAP_TYPE_CONFIGS_GROUP: