Commit 6a33ed50 authored by Max Gurtovoy's avatar Max Gurtovoy Committed by Martin K. Petersen
Browse files

scsi: iscsi: Make iscsi_unregister_transport() return void 

This function always returns 0. We can make it return void to simplify the
code. Also, no caller ever checks the return value of this function.

Link: https://lore.kernel.org/r/20220616080210.18531-1-mgurtovoy@nvidia.com


Reviewed-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarMax Gurtovoy <mgurtovoy@nvidia.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent cb142b6d

drivers/scsi/scsi_transport_iscsi.c

+1 −3
Original line number Diff line number Diff line
@@ -4807,7 +4807,7 @@ iscsi_register_transport(struct iscsi_transport *tt) 
}

EXPORT_SYMBOL_GPL(iscsi_register_transport);



int iscsi_unregister_transport(struct iscsi_transport *tt)

void iscsi_unregister_transport(struct iscsi_transport *tt)

{

	struct iscsi_internal *priv;

	unsigned long flags;
@@ -4830,8 +4830,6 @@ int iscsi_unregister_transport(struct iscsi_transport *tt) 
	sysfs_remove_group(&priv->dev.kobj, &iscsi_transport_group);

	device_unregister(&priv->dev);

	mutex_unlock(&rx_queue_mutex);



	return 0;

}

EXPORT_SYMBOL_GPL(iscsi_unregister_transport);

include/scsi/scsi_transport_iscsi.h

+1 −1
Original line number Diff line number Diff line
@@ -162,7 +162,7 @@ struct iscsi_transport { 
 * transport registration upcalls

 */

extern struct scsi_transport_template *iscsi_register_transport(struct iscsi_transport *tt);

extern int iscsi_unregister_transport(struct iscsi_transport *tt);

extern void iscsi_unregister_transport(struct iscsi_transport *tt);



/*

 * control plane upcalls