Commit 69e131d1 authored by Thinh Nguyen's avatar Thinh Nguyen Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: gadget: Prevent repeat pullup() 



Don't do soft-disconnect if it's previously done. Likewise, don't do
soft-connect if the device is currently connected and running. It would
break normal operation.

Currently the caller of pullup() (udc's sysfs soft_connect) only checks
if it had initiated disconnect to prevent repeating soft-disconnect. It
doesn't check for soft-connect. To be safe, let's keep the check here
regardless whether the udc core is fixed.

Signed-off-by: default avatarThinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/1c1345bd66c97a9d32f77d63aaadd04b7b037143.1650593829.git.Thinh.Nguyen@synopsys.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ca05b382

drivers/usb/dwc3/gadget.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -2514,6 +2514,10 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on) 
	int			ret;

	int			ret;





	is_on = !!is_on;

	is_on = !!is_on;



	if (dwc->pullups_connected == is_on)

		return 0;



	dwc->softconnect = is_on;

	dwc->softconnect = is_on;

	/*

	/*

	 * Per databook, when we want to stop the gadget, if a control transfer

	 * Per databook, when we want to stop the gadget, if a control transfer