Commit 69beb62f authored by Ye Bin's avatar Ye Bin Committed by Jens Axboe
Browse files

nbd: Fix incorrect error handle when first_minor is illegal in nbd_dev_add 



If first_minor is illegal will goto out_free_idr label, this will miss
cleanup disk.

Fixes: b1a81163 ("block: nbd: add sanity check for first_minor")
Signed-off-by: default avatarYe Bin <yebin10@huawei.com>
Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Link: https://lore.kernel.org/r/20211102015237.2309763-4-yebin10@huawei.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 940c2649

drivers/block/nbd.c

+1 −1
Original line number Diff line number Diff line
@@ -1814,7 +1814,7 @@ static struct nbd_device *nbd_dev_add(int index, unsigned int refs) 
	disk->first_minor = index << part_shift;

	if (disk->first_minor < index || disk->first_minor > MINORMASK) {

		err = -EINVAL;

		goto out_free_idr;

		goto out_err_disk;

	}



	disk->minors = 1 << part_shift;