Commit 699784f7 authored by Parav Pandit's avatar Parav Pandit Committed by David S. Miller
Browse files

devlink: Create a helper function for one parameter registration 



Create and use a helper function for one parameter registration.
Subsequent patch also will reuse this for driver facing routine to
register a single parameter.

Signed-off-by: default avatarParav Pandit <parav@nvidia.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 076b2a9d

net/core/devlink.c

+18 −6
Original line number Diff line number Diff line
@@ -9800,6 +9800,22 @@ static int devlink_param_verify(const struct devlink_param *param) 
		return devlink_param_driver_verify(param);

}



static int __devlink_param_register_one(struct devlink *devlink,

					unsigned int port_index,

					struct list_head *param_list,

					const struct devlink_param *param,

					enum devlink_command reg_cmd)

{

	int err;



	err = devlink_param_verify(param);

	if (err)

		return err;



	return devlink_param_register_one(devlink, port_index,

					  param_list, param, reg_cmd);

}



static int __devlink_params_register(struct devlink *devlink,

				     unsigned int port_index,

				     struct list_head *param_list,
@@ -9814,11 +9830,7 @@ static int __devlink_params_register(struct devlink *devlink, 


	mutex_lock(&devlink->lock);

	for (i = 0; i < params_count; i++, param++) {

		err = devlink_param_verify(param);

		if (err)

			goto rollback;



		err = devlink_param_register_one(devlink, port_index,

		err = __devlink_param_register_one(devlink, port_index,

						   param_list, param, reg_cmd);

		if (err)

			goto rollback;