Commit 698a5c8c authored by Yangtao Li's avatar Yangtao Li Committed by Jaegeuk Kim
Browse files

f2fs: add sanity compress level check for compressed file 



Commit 3fde13f8 ("f2fs: compress: support compress level")
forgot to do basic compress level check, let's add it.

Signed-off-by: default avatarYangtao Li <frank.li@vivo.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 00e120b5

fs/f2fs/inode.c

+78 −29
Original line number Diff line number Diff line
@@ -10,6 +10,8 @@ 
#include <linux/buffer_head.h>

#include <linux/writeback.h>

#include <linux/sched/mm.h>

#include <linux/lz4.h>

#include <linux/zstd.h>



#include "f2fs.h"

#include "node.h"
@@ -202,6 +204,80 @@ void f2fs_inode_chksum_set(struct f2fs_sb_info *sbi, struct page *page) 
	ri->i_inode_checksum = cpu_to_le32(f2fs_inode_chksum(sbi, page));

}



static bool sanity_check_compress_inode(struct inode *inode,

			struct f2fs_inode *ri)

{

	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);

	unsigned char clevel;



	if (ri->i_compress_algorithm >= COMPRESS_MAX) {

		f2fs_warn(sbi,

			"%s: inode (ino=%lx) has unsupported compress algorithm: %u, run fsck to fix",

			__func__, inode->i_ino, ri->i_compress_algorithm);

		goto err;

	}

	if (le64_to_cpu(ri->i_compr_blocks) >

			SECTOR_TO_BLOCK(inode->i_blocks)) {

		f2fs_warn(sbi,

			"%s: inode (ino=%lx) has inconsistent i_compr_blocks:%llu, i_blocks:%llu, run fsck to fix",

			__func__, inode->i_ino, le64_to_cpu(ri->i_compr_blocks),

			SECTOR_TO_BLOCK(inode->i_blocks));

		goto err;

	}

	if (ri->i_log_cluster_size < MIN_COMPRESS_LOG_SIZE ||

		ri->i_log_cluster_size > MAX_COMPRESS_LOG_SIZE) {

		f2fs_warn(sbi,

			"%s: inode (ino=%lx) has unsupported log cluster size: %u, run fsck to fix",

			__func__, inode->i_ino, ri->i_log_cluster_size);

		goto err;

	}



	clevel = le16_to_cpu(ri->i_compress_flag) >>

				COMPRESS_LEVEL_OFFSET;

	switch (ri->i_compress_algorithm) {

	case COMPRESS_LZO:

#ifdef CONFIG_F2FS_FS_LZO

		if (clevel)

			goto err_level;

#endif

		break;

	case COMPRESS_LZORLE:

#ifdef CONFIG_F2FS_FS_LZORLE

		if (clevel)

			goto err_level;

#endif

		break;

	case COMPRESS_LZ4:

#ifdef CONFIG_F2FS_FS_LZ4

#ifdef CONFIG_F2FS_FS_LZ4HC

		if (clevel &&

		   (clevel < LZ4HC_MIN_CLEVEL || clevel > LZ4HC_MAX_CLEVEL))

			goto err_level;

#else

		if (clevel)

			goto err_level;

#endif

#endif

		break;

	case COMPRESS_ZSTD:

#ifdef CONFIG_F2FS_FS_ZSTD

		if (clevel < zstd_min_clevel() || clevel > zstd_max_clevel())

			goto err_level;

#endif

		break;

	default:

		goto err_level;

	}



	return true;

err_level:

	f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported compress level: %u, run fsck to fix",

		  __func__, inode->i_ino, clevel);

err:

	set_sbi_flag(sbi, SBI_NEED_FSCK);

	return false;

}



static bool sanity_check_inode(struct inode *inode, struct page *node_page)

{

	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
@@ -286,35 +362,8 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) 
	if (f2fs_has_extra_attr(inode) && f2fs_sb_has_compression(sbi) &&

			fi->i_flags & F2FS_COMPR_FL &&

			F2FS_FITS_IN_INODE(ri, fi->i_extra_isize,

						i_log_cluster_size)) {

		if (ri->i_compress_algorithm >= COMPRESS_MAX) {

			set_sbi_flag(sbi, SBI_NEED_FSCK);

			f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported "

				"compress algorithm: %u, run fsck to fix",

				  __func__, inode->i_ino,

				  ri->i_compress_algorithm);

			return false;

		}

		if (le64_to_cpu(ri->i_compr_blocks) >

				SECTOR_TO_BLOCK(inode->i_blocks)) {

			set_sbi_flag(sbi, SBI_NEED_FSCK);

			f2fs_warn(sbi, "%s: inode (ino=%lx) has inconsistent "

				"i_compr_blocks:%llu, i_blocks:%llu, run fsck to fix",

				  __func__, inode->i_ino,

				  le64_to_cpu(ri->i_compr_blocks),

				  SECTOR_TO_BLOCK(inode->i_blocks));

			return false;

		}

		if (ri->i_log_cluster_size < MIN_COMPRESS_LOG_SIZE ||

			ri->i_log_cluster_size > MAX_COMPRESS_LOG_SIZE) {

			set_sbi_flag(sbi, SBI_NEED_FSCK);

			f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported "

				"log cluster size: %u, run fsck to fix",

				  __func__, inode->i_ino,

				  ri->i_log_cluster_size);

			return false;

		}

	}

						i_log_cluster_size))

		return sanity_check_compress_inode(inode, ri);



	return true;

}