Commit 697d5cf0 authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Leon Romanovsky
Browse files

IB/qib: Drop redundant pci_enable_pcie_error_reporting() 



pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Reviewed-by: default avatarDennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 512ed119

drivers/infiniband/hw/qib/qib_pcie.c

+0 −8
Original line number Diff line number Diff line
@@ -35,7 +35,6 @@ 
#include <linux/io.h>

#include <linux/delay.h>

#include <linux/vmalloc.h>

#include <linux/aer.h>

#include <linux/module.h>



#include "qib.h"
@@ -105,13 +104,6 @@ int qib_pcie_init(struct pci_dev *pdev, const struct pci_device_id *ent) 
	}



	pci_set_master(pdev);

	ret = pci_enable_pcie_error_reporting(pdev);

	if (ret) {

		qib_early_err(&pdev->dev,

			      "Unable to enable pcie error reporting: %d\n",

			      ret);

		ret = 0;

	}

	goto done;



bail: