Commit 69777e6c authored by Wang Li's avatar Wang Li Committed by Chun-Kuang Hu
Browse files

drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw_init() 



pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWang Li <wangli74@huawei.com>
Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
parent 511cf7d1

drivers/gpu/drm/mediatek/mtk_drm_crtc.c

+1 −1
Original line number Diff line number Diff line
@@ -260,7 +260,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc) 
		drm_connector_list_iter_end(&conn_iter);

	}



	ret = pm_runtime_get_sync(crtc->dev->dev);

	ret = pm_runtime_resume_and_get(crtc->dev->dev);

	if (ret < 0) {

		DRM_ERROR("Failed to enable power domain: %d\n", ret);

		return ret;