Commit 6966d4c4 authored by Yuntao Wang's avatar Yuntao Wang Committed by Andrii Nakryiko
Browse files

libbpf: Remove redundant check in btf_fixup_datasec() 



The check 't->size && t->size != size' is redundant because if t->size
compares unequal to 0, we will just skip straight to sorting variables.

Signed-off-by: default avatarYuntao Wang <ytcoode@gmail.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20220220072750.209215-1-ytcoode@gmail.com
parent 13c6a37d

tools/lib/bpf/libbpf.c

+1 −1
Original line number Diff line number Diff line
@@ -2795,7 +2795,7 @@ static int btf_fixup_datasec(struct bpf_object *obj, struct btf *btf, 
		goto sort_vars;



	ret = find_elf_sec_sz(obj, name, &size);

	if (ret || !size || (t->size && t->size != size)) {

	if (ret || !size) {

		pr_debug("Invalid size for section %s: %u bytes\n", name, size);

		return -ENOENT;

	}