Commit 69657e60 authored by Asmaa Mnebhi's avatar Asmaa Mnebhi Committed by Linus Walleij
Browse files

pinctrl: mlxbf3: Remove gpio_disable_free() 



Remove support for gpio_disable_free() because it is called when the libgpiod
command "gpioset" is invoked. This gives the GPIO control back to hardware which
cancels out the effort to set the GPIO value.

Reminder of the code flow to change a GPIO value from software:
1) All GPIOs are controlled by hardware by default
2) To change the GPIO value, enable software control via a mux.
3) Once software has control over the GPIO pin, the gpio-mlxbf3 driver
   will be able to change the direction and value of the GPIO.

When the user runs "gpioset gpiochip0 0=0" for example, the gpio
pin value should change from 1 to 0. In this case, mlxbf3_gpio_request_enable()
is called via gpiochip_generic_request(). The latter switches GPIO control from
hardware to software. Then the GPIO value is changed from 1 to 0. However,
gpio_disable_free() is also called which changes control back to hardware
which changes the GPIO value back to 1.

Fixes: d11f9328 ("pinctrl: mlxbf3: Add pinctrl driver support")
Signed-off-by: default avatarAsmaa Mnebhi <asmaa@nvidia.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20230818164314.8505-2-asmaa@nvidia.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent c0f84760

drivers/pinctrl/pinctrl-mlxbf3.c

+0 −14
Original line number Diff line number Diff line
@@ -223,26 +223,12 @@ static int mlxbf3_gpio_request_enable(struct pinctrl_dev *pctldev, 
	return 0;

}



static void mlxbf3_gpio_disable_free(struct pinctrl_dev *pctldev,

				    struct pinctrl_gpio_range *range,

				    unsigned int offset)

{

	struct mlxbf3_pinctrl *priv = pinctrl_dev_get_drvdata(pctldev);



	/* disable GPIO functionality by giving control back to hardware */

	if (offset < MLXBF3_NGPIOS_GPIO0)

		writel(BIT(offset), priv->fw_ctrl_clr0);

	else

		writel(BIT(offset % MLXBF3_NGPIOS_GPIO0), priv->fw_ctrl_clr1);

}



static const struct pinmux_ops mlxbf3_pmx_ops = {

	.get_functions_count = mlxbf3_pmx_get_funcs_count,

	.get_function_name = mlxbf3_pmx_get_func_name,

	.get_function_groups = mlxbf3_pmx_get_groups,

	.set_mux = mlxbf3_pmx_set,

	.gpio_request_enable = mlxbf3_gpio_request_enable,

	.gpio_disable_free = mlxbf3_gpio_disable_free,

};



static struct pinctrl_desc mlxbf3_pin_desc = {