Commit 6942a284 authored by Vadim Fedorenko's avatar Vadim Fedorenko Committed by Jakub Kicinski
Browse files

net/tls: make inline helpers protocol-aware 



Inline functions defined in tls.h have a lot of AES-specific
constants. Remove these constants and change argument to struct
tls_prot_info to have an access to cipher type in later patches

Signed-off-by: default avatarVadim Fedorenko <vfedorenko@novek.ru>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 594e31bc

include/net/tls.h

+12 −14
Original line number Diff line number Diff line
@@ -502,31 +502,30 @@ static inline void tls_advance_record_sn(struct sock *sk, 
		tls_err_abort(sk, EBADMSG);



	if (prot->version != TLS_1_3_VERSION)

		tls_bigint_increment(ctx->iv + TLS_CIPHER_AES_GCM_128_SALT_SIZE,

		tls_bigint_increment(ctx->iv + prot->salt_size,

				     prot->iv_size);

}



static inline void tls_fill_prepend(struct tls_context *ctx,

			     char *buf,

			     size_t plaintext_len,

			     unsigned char record_type,

			     int version)

			     unsigned char record_type)

{

	struct tls_prot_info *prot = &ctx->prot_info;

	size_t pkt_len, iv_size = prot->iv_size;



	pkt_len = plaintext_len + prot->tag_size;

	if (version != TLS_1_3_VERSION) {

	if (prot->version != TLS_1_3_VERSION) {

		pkt_len += iv_size;



		memcpy(buf + TLS_NONCE_OFFSET,

		       ctx->tx.iv + TLS_CIPHER_AES_GCM_128_SALT_SIZE, iv_size);

		       ctx->tx.iv + prot->salt_size, iv_size);

	}



	/* we cover nonce explicit here as well, so buf should be of

	 * size KTLS_DTLS_HEADER_SIZE + KTLS_DTLS_NONCE_EXPLICIT_SIZE

	 */

	buf[0] = version == TLS_1_3_VERSION ?

	buf[0] = prot->version == TLS_1_3_VERSION ?

		   TLS_RECORD_TYPE_DATA : record_type;

	/* Note that VERSION must be TLS_1_2 for both TLS1.2 and TLS1.3 */

	buf[1] = TLS_1_2_VERSION_MINOR;
@@ -539,18 +538,17 @@ static inline void tls_fill_prepend(struct tls_context *ctx, 
static inline void tls_make_aad(char *buf,

				size_t size,

				char *record_sequence,

				int record_sequence_size,

				unsigned char record_type,

				int version)

				struct tls_prot_info *prot)

{

	if (version != TLS_1_3_VERSION) {

		memcpy(buf, record_sequence, record_sequence_size);

	if (prot->version != TLS_1_3_VERSION) {

		memcpy(buf, record_sequence, prot->rec_seq_size);

		buf += 8;

	} else {

		size += TLS_CIPHER_AES_GCM_128_TAG_SIZE;

		size += prot->tag_size;

	}



	buf[0] = version == TLS_1_3_VERSION ?

	buf[0] = prot->version == TLS_1_3_VERSION ?

		  TLS_RECORD_TYPE_DATA : record_type;

	buf[1] = TLS_1_2_VERSION_MAJOR;

	buf[2] = TLS_1_2_VERSION_MINOR;
@@ -558,11 +556,11 @@ static inline void tls_make_aad(char *buf, 
	buf[4] = size & 0xFF;

}



static inline void xor_iv_with_seq(int version, char *iv, char *seq)

static inline void xor_iv_with_seq(struct tls_prot_info *prot, char *iv, char *seq)

{

	int i;



	if (version == TLS_1_3_VERSION) {

	if (prot->version == TLS_1_3_VERSION) {

		for (i = 0; i < 8; i++)

			iv[i + 4] ^= seq[i];

	}

net/tls/tls_device.c

+1 −1
Original line number Diff line number Diff line
@@ -327,7 +327,7 @@ static int tls_device_record_close(struct sock *sk, 
	/* fill prepend */

	tls_fill_prepend(ctx, skb_frag_address(&record->frags[0]),

			 record->len - prot->overhead_size,

			 record_type, prot->version);

			 record_type);

	return ret;

}

net/tls/tls_device_fallback.c

+7 −6
Original line number Diff line number Diff line
@@ -49,7 +49,8 @@ static int tls_enc_record(struct aead_request *aead_req, 
			  struct crypto_aead *aead, char *aad,

			  char *iv, __be64 rcd_sn,

			  struct scatter_walk *in,

			  struct scatter_walk *out, int *in_len)

			  struct scatter_walk *out, int *in_len,

			  struct tls_prot_info *prot)

{

	unsigned char buf[TLS_HEADER_SIZE + TLS_CIPHER_AES_GCM_128_IV_SIZE];

	struct scatterlist sg_in[3];
@@ -73,8 +74,7 @@ static int tls_enc_record(struct aead_request *aead_req, 
	len -= TLS_CIPHER_AES_GCM_128_IV_SIZE;



	tls_make_aad(aad, len - TLS_CIPHER_AES_GCM_128_TAG_SIZE,

		(char *)&rcd_sn, sizeof(rcd_sn), buf[0],

		TLS_1_2_VERSION);

		(char *)&rcd_sn, buf[0], prot);



	memcpy(iv + TLS_CIPHER_AES_GCM_128_SALT_SIZE, buf + TLS_HEADER_SIZE,

	       TLS_CIPHER_AES_GCM_128_IV_SIZE);
@@ -140,7 +140,7 @@ static struct aead_request *tls_alloc_aead_request(struct crypto_aead *aead, 
static int tls_enc_records(struct aead_request *aead_req,

			   struct crypto_aead *aead, struct scatterlist *sg_in,

			   struct scatterlist *sg_out, char *aad, char *iv,

			   u64 rcd_sn, int len)

			   u64 rcd_sn, int len, struct tls_prot_info *prot)

{

	struct scatter_walk out, in;

	int rc;
@@ -150,7 +150,7 @@ static int tls_enc_records(struct aead_request *aead_req, 


	do {

		rc = tls_enc_record(aead_req, aead, aad, iv,

				    cpu_to_be64(rcd_sn), &in, &out, &len);

				    cpu_to_be64(rcd_sn), &in, &out, &len, prot);

		rcd_sn++;



	} while (rc == 0 && len);
@@ -348,7 +348,8 @@ static struct sk_buff *tls_enc_skb(struct tls_context *tls_ctx, 
		    payload_len, sync_size, dummy_buf);



	if (tls_enc_records(aead_req, ctx->aead_send, sg_in, sg_out, aad, iv,

			    rcd_sn, sync_size + payload_len) < 0)

			    rcd_sn, sync_size + payload_len,

			    &tls_ctx->prot_info) < 0)

		goto free_nskb;



	complete_skb(nskb, skb, tcp_payload_offset);

net/tls/tls_sw.c

+5 −7
Original line number Diff line number Diff line
@@ -505,7 +505,7 @@ static int tls_do_encryption(struct sock *sk, 
	memcpy(&rec->iv_data[iv_offset], tls_ctx->tx.iv,

	       prot->iv_size + prot->salt_size);



	xor_iv_with_seq(prot->version, rec->iv_data, tls_ctx->tx.rec_seq);

	xor_iv_with_seq(prot, rec->iv_data, tls_ctx->tx.rec_seq);



	sge->offset += prot->prepend_size;

	sge->length -= prot->prepend_size;
@@ -748,14 +748,13 @@ static int tls_push_record(struct sock *sk, int flags, 
	sg_chain(rec->sg_aead_out, 2, &msg_en->sg.data[i]);



	tls_make_aad(rec->aad_space, msg_pl->sg.size + prot->tail_size,

		     tls_ctx->tx.rec_seq, prot->rec_seq_size,

		     record_type, prot->version);

		     tls_ctx->tx.rec_seq, record_type, prot);



	tls_fill_prepend(tls_ctx,

			 page_address(sg_page(&msg_en->sg.data[i])) +

			 msg_en->sg.data[i].offset,

			 msg_pl->sg.size + prot->tail_size,

			 record_type, prot->version);

			 record_type);



	tls_ctx->pending_open_record_frags = false;
@@ -1471,13 +1470,12 @@ static int decrypt_internal(struct sock *sk, struct sk_buff *skb, 
	else

		memcpy(iv + iv_offset, tls_ctx->rx.iv, prot->salt_size);



	xor_iv_with_seq(prot->version, iv, tls_ctx->rx.rec_seq);

	xor_iv_with_seq(prot, iv, tls_ctx->rx.rec_seq);



	/* Prepare AAD */

	tls_make_aad(aad, rxm->full_len - prot->overhead_size +

		     prot->tail_size,

		     tls_ctx->rx.rec_seq, prot->rec_seq_size,

		     ctx->control, prot->version);

		     tls_ctx->rx.rec_seq, ctx->control, prot);



	/* Prepare sgin */

	sg_init_table(sgin, n_sgin);