Commit 692a3b9a authored by Viresh Kumar's avatar Viresh Kumar Committed by Rafael J. Wysocki
Browse files

cpufreq: acpi: Remove acpi_cpufreq_cpu_ready() 



The ready() callback was implemented earlier for acpi-cpufreq driver as
we wanted to use policy->cpuinfo.max_freq for which the policy was
required to be verified.

That is no longer the case and we can do the pr_warn() right from
->init() callback now. Remove acpi_cpufreq_cpu_ready().

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent b2a6181e

drivers/cpufreq/acpi-cpufreq.c

+3 −11
Original line number Diff line number Diff line
@@ -889,6 +889,9 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) 
	policy->fast_switch_possible = !acpi_pstate_strict &&

		!(policy_is_shared(policy) && policy->shared_type != CPUFREQ_SHARED_TYPE_ANY);



	if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency)

		pr_warn(FW_WARN "P-state 0 is not max freq\n");



	return result;



err_unreg:
@@ -918,16 +921,6 @@ static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) 
	return 0;

}



static void acpi_cpufreq_cpu_ready(struct cpufreq_policy *policy)

{

	struct acpi_processor_performance *perf = per_cpu_ptr(acpi_perf_data,

							      policy->cpu);

	unsigned int freq = policy->freq_table[0].frequency;



	if (perf->states[0].core_frequency * 1000 != freq)

		pr_warn(FW_WARN "P-state 0 is not max freq\n");

}



static int acpi_cpufreq_resume(struct cpufreq_policy *policy)

{

	struct acpi_cpufreq_data *data = policy->driver_data;
@@ -955,7 +948,6 @@ static struct cpufreq_driver acpi_cpufreq_driver = { 
	.bios_limit	= acpi_processor_get_bios_limit,

	.init		= acpi_cpufreq_cpu_init,

	.exit		= acpi_cpufreq_cpu_exit,

	.ready		= acpi_cpufreq_cpu_ready,

	.resume		= acpi_cpufreq_resume,

	.name		= "acpi-cpufreq",

	.attr		= acpi_cpufreq_attr,