Commit 691b2bf1 authored by Hangbin Liu's avatar Hangbin Liu Committed by Paolo Abeni
Browse files

bonding: update port speed when getting bond speed 



Andrew reported a bonding issue that if we put an active-back bond on top
of a 802.3ad bond interface. When the 802.3ad bond's speed/duplex changed
dynamically. The upper bonding interface's speed/duplex can't be changed at
the same time, which will show incorrect speed.

Fix it by updating the port speed when calling ethtool.

Reported-by: default avatarAndrew Schorr <ajschorr@alumni.princeton.edu>
Closes: https://lore.kernel.org/netdev/ZEt3hvyREPVdbesO@Laptop-X1/


Signed-off-by: default avatarHangbin Liu <liuhangbin@gmail.com>
Acked-by: default avatarJay Vosburgh <jay.vosburgh@canonical.com>
Link: https://lore.kernel.org/r/20230821101008.797482-1-liuhangbin@gmail.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 43c28172

drivers/net/bonding/bond_main.c

+1 −0
Original line number Diff line number Diff line
@@ -5718,6 +5718,7 @@ static int bond_ethtool_get_link_ksettings(struct net_device *bond_dev, 
	 */

	bond_for_each_slave(bond, slave, iter) {

		if (bond_slave_can_tx(slave)) {

			bond_update_speed_duplex(slave);

			if (slave->speed != SPEED_UNKNOWN) {

				if (BOND_MODE(bond) == BOND_MODE_BROADCAST)

					speed = bond_mode_bcast_speed(slave,