Unverified Commit 68fffc19 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

spi: tegra114: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200901152713.18629-10-krzk@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 74ee6dc1

drivers/spi/spi-tegra114.c

+3 −8
Original line number Diff line number Diff line
@@ -664,16 +664,11 @@ static int tegra_spi_init_dma_param(struct tegra_spi_data *tspi, 
	struct dma_chan *dma_chan;

	u32 *dma_buf;

	dma_addr_t dma_phys;

	int ret;



	dma_chan = dma_request_chan(tspi->dev, dma_to_memory ? "rx" : "tx");

	if (IS_ERR(dma_chan)) {

		ret = PTR_ERR(dma_chan);

		if (ret != -EPROBE_DEFER)

			dev_err(tspi->dev,

				"Dma channel is not available: %d\n", ret);

		return ret;

	}

	if (IS_ERR(dma_chan))

		return dev_err_probe(tspi->dev, PTR_ERR(dma_chan),

				     "Dma channel is not available\n");



	dma_buf = dma_alloc_coherent(tspi->dev, tspi->dma_buf_size,

				&dma_phys, GFP_KERNEL);