Commit 68fe1db0 authored by Alexander Aring's avatar Alexander Aring Committed by Stefan Schmidt
Browse files

net: ieee802154: return -EINVAL for unknown addr type 



This patch adds handling to return -EINVAL for an unknown addr type. The
current behaviour is to return 0 as successful but the size of an
unknown addr type is not defined and should return an error like -EINVAL.

Fixes: 94160108 ("net/ieee802154: fix uninit value bug in dgram_sendmsg")
Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20221006020237.318511-1-aahringo@redhat.com


Signed-off-by: default avatarStefan Schmidt <stefan@datenfreihafen.org>
parent 1d22f78d

include/net/ieee802154_netdev.h

+9 −3
Original line number Diff line number Diff line
@@ -185,21 +185,27 @@ static inline int 
ieee802154_sockaddr_check_size(struct sockaddr_ieee802154 *daddr, int len)

{

	struct ieee802154_addr_sa *sa;

	int ret = 0;



	sa = &daddr->addr;

	if (len < IEEE802154_MIN_NAMELEN)

		return -EINVAL;

	switch (sa->addr_type) {

	case IEEE802154_ADDR_NONE:

		break;

	case IEEE802154_ADDR_SHORT:

		if (len < IEEE802154_NAMELEN_SHORT)

			return -EINVAL;

			ret = -EINVAL;

		break;

	case IEEE802154_ADDR_LONG:

		if (len < IEEE802154_NAMELEN_LONG)

			return -EINVAL;

			ret = -EINVAL;

		break;

	default:

		ret = -EINVAL;

		break;

	}

	return 0;

	return ret;

}



static inline void ieee802154_addr_from_sa(struct ieee802154_addr *a,