Commit 68ea1b2c authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Wolfram Sang
Browse files

i2c: core: Use generic_handle_irq_safe() in i2c_handle_smbus_host_notify(). 



The i2c-i801 driver invokes i2c_handle_smbus_host_notify() from his
interrupt service routine. On PREEMPT_RT i2c-i801's handler is forced
threaded with enabled interrupts which leads to a warning by
handle_irq_event_percpu() assuming that irq_default_primary_handler()
enabled interrupts.

i2c-i801's interrupt handler can't be made non-threaded because the
interrupt line is shared with other devices.

Use generic_handle_irq_safe() which can invoked with disabled and enabled
interrupts.

Reported-by: default avatarMichael Below <below@judiz.de>
Link: https://bugs.debian.org/1002537


Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: default avatarOleksandr Natalenko <oleksandr@natalenko.name>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 24e3bb74

drivers/i2c/i2c-core-base.c

+1 −1
Original line number Diff line number Diff line
@@ -1424,7 +1424,7 @@ int i2c_handle_smbus_host_notify(struct i2c_adapter *adap, unsigned short addr) 
	if (irq <= 0)

		return -ENXIO;



	generic_handle_irq(irq);

	generic_handle_irq_safe(irq);



	return 0;

}