Commit 68e3f61e authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Will Deacon
Browse files

ARM: perf: Mark all accessor functions inline 



When just including <asm/arm_pmuv3.h>:

    arch/arm/include/asm/arm_pmuv3.h:110:13: error: ‘write_pmevtypern’ defined but not used [-Werror=unused-function]
      110 | static void write_pmevtypern(int n, unsigned long val)
	  |             ^~~~~~~~~~~~~~~~
    arch/arm/include/asm/arm_pmuv3.h:103:13: error: ‘write_pmevcntrn’ defined but not used [-Werror=unused-function]
      103 | static void write_pmevcntrn(int n, unsigned long val)
	  |             ^~~~~~~~~~~~~~~
    arch/arm/include/asm/arm_pmuv3.h:95:22: error: ‘read_pmevcntrn’ defined but not used [-Werror=unused-function]
       95 | static unsigned long read_pmevcntrn(int n)
	  |                      ^~~~~~~~~~~~~~

Fix this by adding the missing "inline" keywords to the three accessor
functions that lack them.

Fixes: 009d6dc8 ("ARM: perf: Allow the use of the PMUv3 driver on 32bit ARM")
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Acked-by: default avatarMark Rutland <mark.rutland@arm.com>
Reviewed-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/3a7d9bc7470aa2d85696ee9765c74f8c03fb5454.1683561482.git.geert+renesas@glider.be


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent b0abde80

arch/arm/include/asm/arm_pmuv3.h

+3 −3
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ 


#define RETURN_READ_PMEVCNTRN(n) \

	return read_sysreg(PMEVCNTR##n)

static unsigned long read_pmevcntrn(int n)

static inline unsigned long read_pmevcntrn(int n)

{

	PMEVN_SWITCH(n, RETURN_READ_PMEVCNTRN);

	return 0;
@@ -100,14 +100,14 @@ static unsigned long read_pmevcntrn(int n) 


#define WRITE_PMEVCNTRN(n) \

	write_sysreg(val, PMEVCNTR##n)

static void write_pmevcntrn(int n, unsigned long val)

static inline void write_pmevcntrn(int n, unsigned long val)

{

	PMEVN_SWITCH(n, WRITE_PMEVCNTRN);

}



#define WRITE_PMEVTYPERN(n) \

	write_sysreg(val, PMEVTYPER##n)

static void write_pmevtypern(int n, unsigned long val)

static inline void write_pmevtypern(int n, unsigned long val)

{

	PMEVN_SWITCH(n, WRITE_PMEVTYPERN);

}