Commit 68dbe80f authored by Koba Ko's avatar Koba Ko Committed by Herbert Xu
Browse files

crypto: ccp - Release dma channels before dmaengine unrgister 



A warning is shown during shutdown,

__dma_async_device_channel_unregister called while 2 clients hold a reference
WARNING: CPU: 15 PID: 1 at drivers/dma/dmaengine.c:1110 __dma_async_device_channel_unregister+0xb7/0xc0

Call dma_release_channel for occupied channles before dma_async_device_unregister.

Fixes: 54cce8ec ("crypto: ccp - ccp_dmaengine_unregister release dma channels")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarKoba Ko <koba.ko@canonical.com>
Acked-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 24ddd4e1

drivers/crypto/ccp/ccp-dmaengine.c

+5 −1
Original line number Diff line number Diff line
@@ -641,6 +641,10 @@ static void ccp_dma_release(struct ccp_device *ccp) 
	for (i = 0; i < ccp->cmd_q_count; i++) {

		chan = ccp->ccp_dma_chan + i;

		dma_chan = &chan->dma_chan;



		if (dma_chan->client_count)

			dma_release_channel(dma_chan);



		tasklet_kill(&chan->cleanup_tasklet);

		list_del_rcu(&dma_chan->device_node);

	}
@@ -766,8 +770,8 @@ void ccp_dmaengine_unregister(struct ccp_device *ccp) 
	if (!dmaengine)

		return;



	dma_async_device_unregister(dma_dev);

	ccp_dma_release(ccp);

	dma_async_device_unregister(dma_dev);



	kmem_cache_destroy(ccp->dma_desc_cache);

	kmem_cache_destroy(ccp->dma_cmd_cache);