Unverified Commit 68c8704d authored by Paul Cercueil's avatar Paul Cercueil
Browse files

drm: atmel-hlcdc: Remove #ifdef guards for PM related functions 



Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handle
the .suspend/.resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_SUSPEND is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Reviewed-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221129191733.137897-9-paul@crapouillou.net
parent 612e241f

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c

+4 −5
Original line number Diff line number Diff line
@@ -784,7 +784,6 @@ static int atmel_hlcdc_dc_drm_remove(struct platform_device *pdev) 
	return 0;

}



#ifdef CONFIG_PM_SLEEP

static int atmel_hlcdc_dc_drm_suspend(struct device *dev)

{

	struct drm_device *drm_dev = dev_get_drvdata(dev);
@@ -815,10 +814,10 @@ static int atmel_hlcdc_dc_drm_resume(struct device *dev) 


	return drm_atomic_helper_resume(drm_dev, dc->suspend.state);

}

#endif



static SIMPLE_DEV_PM_OPS(atmel_hlcdc_dc_drm_pm_ops,

		atmel_hlcdc_dc_drm_suspend, atmel_hlcdc_dc_drm_resume);

static DEFINE_SIMPLE_DEV_PM_OPS(atmel_hlcdc_dc_drm_pm_ops,

				atmel_hlcdc_dc_drm_suspend,

				atmel_hlcdc_dc_drm_resume);



static const struct of_device_id atmel_hlcdc_dc_of_match[] = {

	{ .compatible = "atmel,hlcdc-display-controller" },
@@ -830,7 +829,7 @@ static struct platform_driver atmel_hlcdc_dc_platform_driver = { 
	.remove	= atmel_hlcdc_dc_drm_remove,

	.driver	= {

		.name	= "atmel-hlcdc-display-controller",

		.pm	= &atmel_hlcdc_dc_drm_pm_ops,

		.pm	= pm_sleep_ptr(&atmel_hlcdc_dc_drm_pm_ops),

		.of_match_table = atmel_hlcdc_dc_of_match,

	},

};