Commit 6896cc4d authored by Amit Cohen's avatar Amit Cohen Committed by David S. Miller
Browse files

devlink: Add layer 3 generic packet traps 



Add packet traps that can report packets that were dropped during layer
3 forwarding.

Signed-off-by: default avatarAmit Cohen <amitc@mellanox.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c55b810a

Documentation/networking/devlink-trap.rst

+41 −0
Original line number Diff line number Diff line
@@ -162,6 +162,47 @@ be added to the following table: 
     - ``drop``

     - Traps packets that the device decided to drop because they could not be

       enqueued to a transmission queue which is full

   * - ``non_ip``

     - ``drop``

     - Traps packets that the device decided to drop because they need to

       undergo a layer 3 lookup, but are not IP or MPLS packets

   * - ``uc_dip_over_mc_dmac``

     - ``drop``

     - Traps packets that the device decided to drop because they need to be

       routed and they have a unicast destination IP and a multicast destination

       MAC

   * - ``dip_is_loopback_address``

     - ``drop``

     - Traps packets that the device decided to drop because they need to be

       routed and their destination IP is the loopback address (i.e., 127.0.0.0/8

       and ::1/128)

   * - ``sip_is_mc``

     - ``drop``

     - Traps packets that the device decided to drop because they need to be

       routed and their source IP is multicast (i.e., 224.0.0.0/8 and ff::/8)

   * - ``sip_is_loopback_address``

     - ``drop``

     - Traps packets that the device decided to drop because they need to be

       routed and their source IP is the loopback address (i.e., 127.0.0.0/8 and ::1/128)

   * - ``ip_header_corrupted``

     - ``drop``

     - Traps packets that the device decided to drop because they need to be

       routed and their IP header is corrupted: wrong checksum, wrong IP version

       or too short Internet Header Length (IHL)

   * - ``ipv4_sip_is_limited_bc``

     - ``drop``

     - Traps packets that the device decided to drop because they need to be

       routed and their source IP is limited broadcast (i.e., 255.255.255.255/32)

   * - ``ipv6_mc_dip_reserved_scope``

     - ``drop``

     - Traps IPv6 packets that the device decided to drop because they need to

       be routed and their IPv6 multicast destination IP has a reserved scope

       (i.e., ffx0::/16)

   * - ``ipv6_mc_dip_interface_local_scope``

     - ``drop``

     - Traps IPv6 packets that the device decided to drop because they need to

       be routed and their IPv6 multicast destination IP has an interface-local scope

       (i.e., ffx1::/16)



Driver-specific Packet Traps

============================

include/net/devlink.h

+27 −0
Original line number Diff line number Diff line
@@ -569,6 +569,15 @@ enum devlink_trap_generic_id { 
	DEVLINK_TRAP_GENERIC_ID_BLACKHOLE_ROUTE,

	DEVLINK_TRAP_GENERIC_ID_TTL_ERROR,

	DEVLINK_TRAP_GENERIC_ID_TAIL_DROP,

	DEVLINK_TRAP_GENERIC_ID_NON_IP_PACKET,

	DEVLINK_TRAP_GENERIC_ID_UC_DIP_MC_DMAC,

	DEVLINK_TRAP_GENERIC_ID_DIP_LB,

	DEVLINK_TRAP_GENERIC_ID_SIP_MC,

	DEVLINK_TRAP_GENERIC_ID_SIP_LB,

	DEVLINK_TRAP_GENERIC_ID_CORRUPTED_IP_HDR,

	DEVLINK_TRAP_GENERIC_ID_IPV4_SIP_BC,

	DEVLINK_TRAP_GENERIC_ID_IPV6_MC_DIP_RESERVED_SCOPE,

	DEVLINK_TRAP_GENERIC_ID_IPV6_MC_DIP_INTERFACE_LOCAL_SCOPE,



	/* Add new generic trap IDs above */

	__DEVLINK_TRAP_GENERIC_ID_MAX,
@@ -607,6 +616,24 @@ enum devlink_trap_group_generic_id { 
	"ttl_value_is_too_small"

#define DEVLINK_TRAP_GENERIC_NAME_TAIL_DROP \

	"tail_drop"

#define DEVLINK_TRAP_GENERIC_NAME_NON_IP_PACKET \

	"non_ip"

#define DEVLINK_TRAP_GENERIC_NAME_UC_DIP_MC_DMAC \

	"uc_dip_over_mc_dmac"

#define DEVLINK_TRAP_GENERIC_NAME_DIP_LB \

	"dip_is_loopback_address"

#define DEVLINK_TRAP_GENERIC_NAME_SIP_MC \

	"sip_is_mc"

#define DEVLINK_TRAP_GENERIC_NAME_SIP_LB \

	"sip_is_loopback_address"

#define DEVLINK_TRAP_GENERIC_NAME_CORRUPTED_IP_HDR \

	"ip_header_corrupted"

#define DEVLINK_TRAP_GENERIC_NAME_IPV4_SIP_BC \

	"ipv4_sip_is_limited_bc"

#define DEVLINK_TRAP_GENERIC_NAME_IPV6_MC_DIP_RESERVED_SCOPE \

	"ipv6_mc_dip_reserved_scope"

#define DEVLINK_TRAP_GENERIC_NAME_IPV6_MC_DIP_INTERFACE_LOCAL_SCOPE \

	"ipv6_mc_dip_interface_local_scope"



#define DEVLINK_TRAP_GROUP_GENERIC_NAME_L2_DROPS \

	"l2_drops"

net/core/devlink.c

+9 −0
Original line number Diff line number Diff line
@@ -7602,6 +7602,15 @@ static const struct devlink_trap devlink_trap_generic[] = { 
	DEVLINK_TRAP(BLACKHOLE_ROUTE, DROP),

	DEVLINK_TRAP(TTL_ERROR, EXCEPTION),

	DEVLINK_TRAP(TAIL_DROP, DROP),

	DEVLINK_TRAP(NON_IP_PACKET, DROP),

	DEVLINK_TRAP(UC_DIP_MC_DMAC, DROP),

	DEVLINK_TRAP(DIP_LB, DROP),

	DEVLINK_TRAP(SIP_MC, DROP),

	DEVLINK_TRAP(SIP_LB, DROP),

	DEVLINK_TRAP(CORRUPTED_IP_HDR, DROP),

	DEVLINK_TRAP(IPV4_SIP_BC, DROP),

	DEVLINK_TRAP(IPV6_MC_DIP_RESERVED_SCOPE, DROP),

	DEVLINK_TRAP(IPV6_MC_DIP_INTERFACE_LOCAL_SCOPE, DROP),

};



#define DEVLINK_TRAP_GROUP(_id)						      \