Commit 68511b48 authored by Roi Dayan's avatar Roi Dayan Committed by Saeed Mahameed
Browse files

net/mlx5e: TC, Remove redundant error logging 



Remove redundant and trivial error logging when trying to
offload mirred device with unsupported devices.
Using OVS could hit those a lot and the errors are still
logged in extack.

Signed-off-by: default avatarRoi Dayan <roid@nvidia.com>
Reviewed-by: default avatarMaor Dickman <maord@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent be23511e

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/mirred.c

+0 −8
Original line number Diff line number Diff line
@@ -45,14 +45,10 @@ verify_uplink_forwarding(struct mlx5e_priv *priv, 
					termination_table_raw_traffic)) {

		NL_SET_ERR_MSG_MOD(extack,

				   "devices are both uplink, can't offload forwarding");

			pr_err("devices %s %s are both uplink, can't offload forwarding\n",

			       priv->netdev->name, out_dev->name);

			return -EOPNOTSUPP;

	} else if (out_dev != rep_priv->netdev) {

		NL_SET_ERR_MSG_MOD(extack,

				   "devices are not the same uplink, can't offload forwarding");

		pr_err("devices %s %s are both uplink but not the same, can't offload forwarding\n",

		       priv->netdev->name, out_dev->name);

		return -EOPNOTSUPP;

	}

	return 0;
@@ -160,10 +156,6 @@ tc_act_can_offload_mirred(struct mlx5e_tc_act_parse_state *parse_state, 
	}



	NL_SET_ERR_MSG_MOD(extack, "devices are not on same switch HW, can't offload forwarding");

	netdev_warn(priv->netdev,

		    "devices %s %s not on same switch HW, can't offload forwarding\n",

		    netdev_name(priv->netdev),

		    out_dev->name);



	return false;

}