Commit 6840bdd7 authored by Marc Zyngier's avatar Marc Zyngier Committed by Catalin Marinas
Browse files

arm64: KVM: Use per-CPU vector when BP hardening is enabled 



Now that we have per-CPU vectors, let's plug then in the KVM/arm64 code.

Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent 0f15adbb

arch/arm/include/asm/kvm_mmu.h

+10 −0
Original line number Diff line number Diff line
@@ -226,6 +226,16 @@ static inline unsigned int kvm_get_vmid_bits(void) 
	return 8;

}



static inline void *kvm_get_hyp_vector(void)

{

	return kvm_ksym_ref(__kvm_hyp_vector);

}



static inline int kvm_map_vectors(void)

{

	return 0;

}



#define kvm_phys_to_vttbr(addr)		(addr)



#endif	/* !__ASSEMBLY__ */

arch/arm64/include/asm/kvm_mmu.h

+38 −0
Original line number Diff line number Diff line
@@ -322,6 +322,44 @@ static inline unsigned int kvm_get_vmid_bits(void) 
	return (cpuid_feature_extract_unsigned_field(reg, ID_AA64MMFR1_VMIDBITS_SHIFT) == 2) ? 16 : 8;

}



#ifdef CONFIG_HARDEN_BRANCH_PREDICTOR

#include <asm/mmu.h>



static inline void *kvm_get_hyp_vector(void)

{

	struct bp_hardening_data *data = arm64_get_bp_hardening_data();

	void *vect = kvm_ksym_ref(__kvm_hyp_vector);



	if (data->fn) {

		vect = __bp_harden_hyp_vecs_start +

		       data->hyp_vectors_slot * SZ_2K;



		if (!has_vhe())

			vect = lm_alias(vect);

	}



	return vect;

}



static inline int kvm_map_vectors(void)

{

	return create_hyp_mappings(kvm_ksym_ref(__bp_harden_hyp_vecs_start),

				   kvm_ksym_ref(__bp_harden_hyp_vecs_end),

				   PAGE_HYP_EXEC);

}



#else

static inline void *kvm_get_hyp_vector(void)

{

	return kvm_ksym_ref(__kvm_hyp_vector);

}



static inline int kvm_map_vectors(void)

{

	return 0;

}

#endif



#define kvm_phys_to_vttbr(addr)		phys_to_ttbr(addr)



#endif /* __ASSEMBLY__ */

arch/arm64/kvm/hyp/switch.c

+1 −1
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ static void __hyp_text __activate_traps_vhe(void) 
	val &= ~(CPACR_EL1_FPEN | CPACR_EL1_ZEN);

	write_sysreg(val, cpacr_el1);



	write_sysreg(__kvm_hyp_vector, vbar_el1);

	write_sysreg(kvm_get_hyp_vector(), vbar_el1);

}



static void __hyp_text __activate_traps_nvhe(void)

virt/kvm/arm/arm.c

+7 −1
Original line number Diff line number Diff line
@@ -1158,7 +1158,7 @@ static void cpu_init_hyp_mode(void *dummy) 
	pgd_ptr = kvm_mmu_get_httbr();

	stack_page = __this_cpu_read(kvm_arm_hyp_stack_page);

	hyp_stack_ptr = stack_page + PAGE_SIZE;

	vector_ptr = (unsigned long)kvm_ksym_ref(__kvm_hyp_vector);

	vector_ptr = (unsigned long)kvm_get_hyp_vector();



	__cpu_init_hyp_mode(pgd_ptr, hyp_stack_ptr, vector_ptr);

	__cpu_init_stage2();
@@ -1403,6 +1403,12 @@ static int init_hyp_mode(void) 
		goto out_err;

	}



	err = kvm_map_vectors();

	if (err) {

		kvm_err("Cannot map vectors\n");

		goto out_err;

	}



	/*

	 * Map the Hyp stack pages

	 */