Commit 68331399 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Miquel Raynal
Browse files

mtd: physmap: physmap-bt1-rom: Fix unintentional stack access 



Cast &data to (char *) in order to avoid unintentionally accessing
the stack.

Notice that data is of type u32, so any increment to &data
will be in the order of 4-byte chunks, and this piece of code
is actually intended to be a byte offset.

Fixes: b3e79e76 ("mtd: physmap: Add Baikal-T1 physically mapped ROM support")
Addresses-Coverity-ID: 1497765 ("Out-of-bounds access")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210212104022.GA242669@embeddedor
parent a38fd874

drivers/mtd/maps/physmap-bt1-rom.c

+1 −1
Original line number Diff line number Diff line
@@ -79,7 +79,7 @@ static void __xipram bt1_rom_map_copy_from(struct map_info *map, 
	if (shift) {

		chunk = min_t(ssize_t, 4 - shift, len);

		data = readl_relaxed(src - shift);

		memcpy(to, &data + shift, chunk);

		memcpy(to, (char *)&data + shift, chunk);

		src += chunk;

		to += chunk;

		len -= chunk;