Commit 6830a6ab authored by Alvaro Karsz's avatar Alvaro Karsz Committed by Michael S. Tsirkin
Browse files

vhost-vdpa: print warning when vhost_vdpa_alloc_domain fails 



Add a print explaining why vhost_vdpa_alloc_domain failed if the device
is not IOMMU cache coherent capable.

Without this print, we have no hint why the operation failed.

For example:

$ virsh start <domain>
	error: Failed to start domain <domain>
	error: Unable to open '/dev/vhost-vdpa-<idx>' for vdpa device:
	       Unknown error 524

Suggested-by: default avatarEugenio Perez Martin <eperezma@redhat.com>
Signed-off-by: default avatarAlvaro Karsz <alvaro.karsz@solid-run.com>

Message-Id: <20230202084212.1328530-1-alvaro.karsz@solid-run.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarEugenio Pérez Martin <eperezma@redhat.com>
parent 08707b5c

drivers/vhost/vdpa.c

+4 −1
Original line number Diff line number Diff line
@@ -1151,8 +1151,11 @@ static int vhost_vdpa_alloc_domain(struct vhost_vdpa *v) 
	if (!bus)

		return -EFAULT;



	if (!device_iommu_capable(dma_dev, IOMMU_CAP_CACHE_COHERENCY))

	if (!device_iommu_capable(dma_dev, IOMMU_CAP_CACHE_COHERENCY)) {

		dev_warn_once(&v->dev,

			      "Failed to allocate domain, device is not IOMMU cache coherent capable\n");

		return -ENOTSUPP;

	}



	v->domain = iommu_domain_alloc(bus);

	if (!v->domain)