Commit 67ec2c75 authored by Guo Zhengkui's avatar Guo Zhengkui Committed by Greg Kroah-Hartman
Browse files

usb: gadget: net2280: use swap() instead of open coding it 



Address the following coccicheck warning:
drivers/usb/gadget/udc/net2280.c:940:20-21: WARNING opportunity for swap().
drivers/usb/gadget/udc/net2280.c:944:25-26: WARNING opportunity for swap().

by using swap() for the swapping of variable values and drop the tmp
variables (`tmp` and `end`) that are not needed any more.

Signed-off-by: default avatarGuo Zhengkui <guozhengkui@vivo.com>
Link: https://lore.kernel.org/r/20220407100459.3605-1-guozhengkui@vivo.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b8a19881

drivers/usb/gadget/udc/net2280.c

+3 −11
Original line number Diff line number Diff line
@@ -932,19 +932,11 @@ static void start_dma(struct net2280_ep *ep, struct net2280_request *req) 
static inline void

queue_dma(struct net2280_ep *ep, struct net2280_request *req, int valid)

{

	struct net2280_dma	*end;

	dma_addr_t		tmp;



	/* swap new dummy for old, link; fill and maybe activate */

	end = ep->dummy;

	ep->dummy = req->td;

	req->td = end;



	tmp = ep->td_dma;

	ep->td_dma = req->td_dma;

	req->td_dma = tmp;

	swap(ep->dummy, req->td);

	swap(ep->td_dma, req->td_dma);



	end->dmadesc = cpu_to_le32 (ep->td_dma);

	req->td->dmadesc = cpu_to_le32 (ep->td_dma);



	fill_dma_desc(ep, req, valid);

}