Commit 67c268a5 authored by Zhan Liu's avatar Zhan Liu Committed by Alex Deucher
Browse files

drm/amd/display: Correct DPCD revision for eDP v1.4 



[Why]
eDP version and DPCD revision are different. Per VESA
spec, "The DPCD revision for eDP v1.4 is 13h".

SUPPORTED_LINK_RATES is valid since eDP v1.4 (DPCD_REV_13).

[How]
Correct DPCD_REV for eDP v1.4.

Signed-off-by: default avatarZhan Liu <zhan.liu@amd.com>
Reviewed-by: default avatarNikola Cornij <Nikola.Cornij@amd.com>
Acked-by: default avatarStylon Wang <stylon.wang@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 3bb68cec

drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

+10 −2
Original line number Diff line number Diff line
@@ -2577,7 +2577,11 @@ bool decide_edp_link_settings(struct dc_link *link, struct dc_link_settings *lin 
	struct dc_link_settings current_link_setting;

	uint32_t link_bw;



	if (link->dpcd_caps.dpcd_rev.raw < DPCD_REV_14 ||

	/*

	 * edp_supported_link_rates_count is only valid for eDP v1.4 or higher.

	 * Per VESA eDP spec, "The DPCD revision for eDP v1.4 is 13h"

	 */

	if (link->dpcd_caps.dpcd_rev.raw < DPCD_REV_13 ||

			link->dpcd_caps.edp_supported_link_rates_count == 0) {

		*link_setting = link->verified_link_cap;

		return true;
@@ -4000,7 +4004,11 @@ void detect_edp_sink_caps(struct dc_link *link) 
	link->dpcd_caps.edp_supported_link_rates_count = 0;

	memset(supported_link_rates, 0, sizeof(supported_link_rates));



	if (link->dpcd_caps.dpcd_rev.raw >= DPCD_REV_14 &&

	/*

	 * edp_supported_link_rates_count is only valid for eDP v1.4 or higher.

	 * Per VESA eDP spec, "The DPCD revision for eDP v1.4 is 13h"

	 */

	if (link->dpcd_caps.dpcd_rev.raw >= DPCD_REV_13 &&

			(link->dc->debug.optimize_edp_link_rate ||

			link->reported_link_cap.link_rate == LINK_RATE_UNKNOWN)) {

		// Read DPCD 00010h - 0001Fh 16 bytes at one shot