Commit 6745bc9b authored by Yang Yingliang's avatar Yang Yingliang Committed by Jakub Kicinski
Browse files

amt: remove unnecessary skb pointer check 



The skb pointer will be checked in kfree_skb(), so remove the outside check.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarTaehee Yoo <ap420073@gmail.com>
Link: https://lore.kernel.org/r/20220818093114.2449179-1-yangyingliang@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b690842d

drivers/net/amt.c

+2 −4
Original line number Diff line number Diff line
@@ -2894,7 +2894,6 @@ static void amt_event_work(struct work_struct *work) 
			amt_event_send_request(amt);

			break;

		default:

			if (skb)

			kfree_skb(skb);

			break;

		}
@@ -3033,7 +3032,6 @@ static int amt_dev_stop(struct net_device *dev) 
	cancel_work_sync(&amt->event_wq);

	for (i = 0; i < AMT_MAX_EVENTS; i++) {

		skb = amt->events[i].skb;

		if (skb)

		kfree_skb(skb);

		amt->events[i].event = AMT_EVENT_NONE;

		amt->events[i].skb = NULL;