Commit 6735041f authored by Yang Li's avatar Yang Li Committed by Jason Gunthorpe
Browse files

RDMA/cma: Remove NULL check before dev_{put, hold} 

The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there
is no need to check before using dev_{put, hold}, remove it to silence the
warning:

./drivers/infiniband/core/cma.c:4812:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.

Link: https://lore.kernel.org/r/20230614014328.14007-1-yang.lee@linux.alibaba.com


Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5521


Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 350b6dd4

drivers/infiniband/core/cma.c

+1 −2
Original line number Diff line number Diff line
@@ -4805,7 +4805,6 @@ static void cma_make_mc_event(int status, struct rdma_id_private *id_priv, 
	event->param.ud.qkey = id_priv->qkey;



out:

	if (ndev)

	dev_put(ndev);

}