Commit 67260e8c authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf c2c: Display proper cpu count in nodes column 



There's wrong bitmap considered when checking for cpu count of specific
node.

We do the needed computation for 'set' variable, but at the end we use
the 'c2c_he->cpuset' weight, which shows misleading numbers.

Fixes: 1e181b92 ("perf c2c report: Add 'node' sort key")
Reported-by: default avatarJoe Mario <jmario@redhat.com>
Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20190820140219.28338-1-jolsa@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 39c2ca43

tools/perf/builtin-c2c.c

+1 −1
Original line number Diff line number Diff line
@@ -1107,7 +1107,7 @@ node_entry(struct perf_hpp_fmt *fmt __maybe_unused, struct perf_hpp *hpp, 
			break;

		case 1:

		{

			int num = bitmap_weight(c2c_he->cpuset, c2c.cpus_cnt);

			int num = bitmap_weight(set, c2c.cpus_cnt);

			struct c2c_stats *stats = &c2c_he->node_stats[node];



			ret = scnprintf(hpp->buf, hpp->size, "%2d{%2d ", node, num);