Commit 670451c3 authored by Ben Skeggs's avatar Ben Skeggs Committed by Karol Herbst
Browse files

drm/nouveau/fifo: return ERR_PTR from nvkm_runl_new() 



Callers expect this - not NULL.

Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
Reviewed-by: default avatarKarol Herbst <kherbst@redhat.com>
Reviewed-by: default avatarLyude Paul <lyude@redhat.com>
Signed-off-by: default avatarKarol Herbst <kherbst@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230525003106.3853741-6-skeggsb@gmail.com
parent c546656f

drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c

+2 −2
Original line number Diff line number Diff line
@@ -399,7 +399,7 @@ nvkm_runl_new(struct nvkm_fifo *fifo, int runi, u32 addr, int id_nr) 
	int ret;



	if (!(runl = kzalloc(sizeof(*runl), GFP_KERNEL)))

		return NULL;

		return ERR_PTR(-ENOMEM);



	runl->func = fifo->func->runl;

	runl->fifo = fifo;
@@ -419,7 +419,7 @@ nvkm_runl_new(struct nvkm_fifo *fifo, int runi, u32 addr, int id_nr) 
		    (ret = nvkm_chid_new(&nvkm_chan_event, subdev, id_nr, 0, id_nr, &runl->chid))) {

			RUNL_ERROR(runl, "cgid/chid: %d", ret);

			nvkm_runl_del(runl);

			return NULL;

			return ERR_PTR(ret);

		}

	} else {

		runl->cgid = nvkm_chid_ref(fifo->cgid);